Skip to content

Run latest release of Black - #1127

Closed
johnmhoran wants to merge 1 commit into
mainfrom
1126-run-latest-black
Closed

Run latest release of Black#1127
johnmhoran wants to merge 1 commit into
mainfrom
1126-run-latest-black

Conversation

@johnmhoran

Copy link
Copy Markdown
Member

Reference: #1126

Reference: #1126

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@johnmhoran

Copy link
Copy Markdown
Member Author

@pombredanne @TG1999 It looks like we have a BaseTests.test_codestyle failure here because our test suite uses Black 22.3.0

Collecting black>=22.3.0
  Downloading black-22.3.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.5 MB)

while I have Black 23.1.0 (released 2023-02-04 -- see https://github.com/psf/black/blob/main/CHANGES.md) in my local vulnerablecode venv, which produces a similar failure when I run make test (and make valid updates 40 files locally). Can we update Black in our GH testing to 23.1.0?

@johnmhoran

Copy link
Copy Markdown
Member Author

This PR remains open, awaiting guidance/decision re how we use Black and make valid and deal with the line-spacing issue. Perhaps that has been resolved, but to my knowledge that's not the case. See also #1085.

@pombredanne

pombredanne commented Aug 17, 2023

Copy link
Copy Markdown
Member

We now use a pinned version since 0fe12c6 so this should no longer be an issue and this version of Black should be installed https://github.com/nexB/vulnerablecode/blob/0d9c9b536a5c6281b92bf7b816f8904a7c499632/requirements.txt#L12

Are you running make clean and then make dev to configure the environment?
If so you should not have Black 23.1.0 but the pinned 22.3.0

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not opposed to this latest Black version, but you need to update the setup.cfg rang and the requirements.txt pin too.
Make sure you run from the latest main too as this affects the whole codebase.

@johnmhoran

Copy link
Copy Markdown
Member Author

Thanks. Note that this has been awaiting a response since February. I'll take a look when time permits.

@TG1999 TG1999 closed this Dec 12, 2023
@TG1999

TG1999 commented Dec 12, 2023

Copy link
Copy Markdown
Contributor

We are using the version 23.12.0 of black and it's from skeleton.

@TG1999
TG1999 deleted the 1126-run-latest-black branch December 12, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants